This repository was archived by the owner on Jun 25, 2020. It is now read-only.
Enhanced front matter #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
is there a way to avoid the double cast (is / as YamlScalarNode)?
Contributor
Author
There was a problem hiding this comment.
There is: If I'd project the items with as and filter nulls, and compare the length of the lists. This is more readble in my opinion.
Contributor
|
Thanks for your PR! |
Contributor
|
Good for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262.
Adds a few tests to FrontMatter parsing of more complex datastructures, including failing ones for lists of lists and lists of dictionaries.
Adds (an admittedly uggly) quick-fix for handling of lists in the front-matter.