This repository was archived by the owner on Jun 25, 2020. It is now read-only.
Fix post_url tag #273
Merged
Fix post_url tag #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 5, 2015 16:05
Add a TagFactoryBase class which provide SiteContext for Tags which need it.
|
Is it wanted to have the TagFactoryBase.CreateTag method internal (which prevents tags in plugins to use the TagFactoryBase) ? |
And add tests
Contributor
Author
|
Thanks a lot for the catch! That was a slip. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #245.
Add a TagFactoryBase class which provide SiteContext for Tags which need
it.
The custom Dotliquid is needed until the pull request dotliquid/dotliquid#150 is accepted.