Fix the withdraw delay#1597
Merged
mergify[bot] merged 1 commit intoCodeChain-io:masterfrom Jun 4, 2019
sgkim126:withdraw
Merged
Fix the withdraw delay#1597mergify[bot] merged 1 commit intoCodeChain-io:masterfrom sgkim126:withdraw
mergify[bot] merged 1 commit intoCodeChain-io:masterfrom
sgkim126:withdraw
Conversation
This was referenced Jun 3, 2019
The withdraw delay should be a term at least due to two reasons: 1. It needs the first block of the next term to calculate the penalty for the disloyal validators. 2. There is a time to report double votes of the last block. But it has no reason to be more than a term no byzantine tries to propagate double vote after 1 term. It does nothing because the chain is finalized already.
foriequal0
approved these changes
Jun 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The withdraw delay should be a term at least due to two reasons:
for the disloyal validators.
But it has no reason to be more than a term no byzantine tries to
propagate double vote after 1 term. It does nothing because the chain is
finalized already.