Introduce minimum fees configured by machines by HoOngEe · Pull Request #1827 · CodeChain-io/codechain

HoOngEe · 2019-10-25T11:17:30Z

It resolves #1758
It enables validators to customize fee thresholds for transactions to be included in their mem pools.

majecty

Let's add an integration test with the scenario below:

Node A's minimum fee for a pay transaction is 100CCC
Node B's minimum fee for a pay transaction is 200CCC
Node A creates a Block with a transaction whose fee is 140CCC.
Node B verifies the block successfully.

HoOngEe · 2019-10-28T11:06:19Z

I implemented the integration test you commented.

foriequal0

You've added codechain binary here: remove it from the repository. 811ab50

HoOngEe · 2019-10-29T02:20:20Z

You've added codechain binary here: remove it from the repository. 811ab50

Thank you, I removed it from the commit.

foriequal0 · 2019-10-29T04:49:07Z

core/src/miner/mem_pool.rs

        client_account: &AccountDetails,
    ) -> Result<(), Error> {
-        if origin != TxOrigin::Local && tx.fee < self.minimal_fee {
+        let action_min_fee = self.minimum_fees.min_cost(&tx.action);


Why origin != TxOrigin::Local condition is dropped?

Because I think that's the correct behavior. Some services let users send their transactions via RPC directly to the nodes. In this case, I think the mem pool minimum fees should be applied to such transactions.

Oh. The spec is changed. okay.

I think that we should remain the original behavior. RPC should not be open to the internet. We didn't consider any safety in RPC. All the people who want to send a transaction should have its own CodeChain instance.

How about discussing this with other team members?

Ok then, I'll summary it and make a conversation. Until now, the mem pool's minimal fee is always set to zero.

I changed the behavior not to reject local transactions despite low fees.

test/src/e2e.long/mempoolMinfee.test.ts

majecty

IMO, local transaction should be mined if its fee is low.

It enables validators to customize fee thresholds for transactions to be included in their mempools.

core/src/miner/mem_pool.rs

Transactions whose fees are below the minimum fees configured by the mem pool should be rejected.

The mem pool minimum fees should not affect to the block verifications.

HoOngEe force-pushed the feature/customized-min-fee branch 3 times, most recently from 2d5b4ed to 6bb3025 Compare October 28, 2019 07:25

HoOngEe changed the title ~~[WIP] Introduce the concept of mem pool minimum fee~~ Introduce the concept of mem pool minimum fee Oct 28, 2019

HoOngEe changed the title ~~Introduce the concept of mem pool minimum fee~~ Introduce machine defined minimum fees Oct 28, 2019

HoOngEe requested review from foriequal0 and majecty October 28, 2019 07:29

HoOngEe force-pushed the feature/customized-min-fee branch from 6bb3025 to 803b74b Compare October 28, 2019 07:30

HoOngEe changed the title ~~Introduce machine defined minimum fees~~ Introduce minimum fees configured by machines Oct 28, 2019

majecty requested changes Oct 28, 2019

View reviewed changes

HoOngEe force-pushed the feature/customized-min-fee branch from c9def02 to 7bc179c Compare October 28, 2019 11:05

foriequal0 requested changes Oct 28, 2019

View reviewed changes

HoOngEe force-pushed the feature/customized-min-fee branch 2 times, most recently from a9461e6 to 0cd8de2 Compare October 29, 2019 02:19

majecty approved these changes Oct 29, 2019

View reviewed changes

foriequal0 requested changes Oct 29, 2019

View reviewed changes

test/src/e2e.long/mempoolMinfee.test.ts Outdated Show resolved Hide resolved

test/src/e2e.long/mempoolMinfee.test.ts Outdated Show resolved Hide resolved

majecty requested changes Oct 29, 2019

View reviewed changes

HoOngEe force-pushed the feature/customized-min-fee branch 4 times, most recently from 5806f5e to 1dbc363 Compare October 30, 2019 09:01

HoOngEe requested review from foriequal0 and majecty October 30, 2019 09:03

majecty previously approved these changes Oct 30, 2019

View reviewed changes

HoOngEe dismissed majecty’s stale review via d697014 October 31, 2019 02:52

HoOngEe force-pushed the feature/customized-min-fee branch 2 times, most recently from d697014 to f510c01 Compare October 31, 2019 02:53

HoOngEe added 2 commits October 31, 2019 11:53

Introduce the concept of mem pool minimum fee

24263e6

It enables validators to customize fee thresholds for transactions to be included in their mempools.

Load mem pool fee options from the machine configurations

81c9281

HoOngEe force-pushed the feature/customized-min-fee branch from f510c01 to 0defbce Compare October 31, 2019 02:53

foriequal0 requested changes Oct 31, 2019

View reviewed changes

core/src/miner/mem_pool.rs Outdated Show resolved Hide resolved

HoOngEe force-pushed the feature/customized-min-fee branch from 0defbce to 5d51a5c Compare October 31, 2019 09:23

Add a unit test to test mem pool minimum fees

6a6d909

Transactions whose fees are below the minimum fees configured by the mem pool should be rejected.

HoOngEe force-pushed the feature/customized-min-fee branch from 5d51a5c to faf9f22 Compare October 31, 2019 09:44

foriequal0 previously approved these changes Nov 1, 2019

View reviewed changes

Add an e2e test about the mem pool minimum fees

74549e7

The mem pool minimum fees should not affect to the block verifications.

HoOngEe dismissed foriequal0’s stale review via 74549e7 November 1, 2019 03:32

HoOngEe force-pushed the feature/customized-min-fee branch from faf9f22 to 74549e7 Compare November 1, 2019 03:32

majecty approved these changes Nov 1, 2019

View reviewed changes

foriequal0 approved these changes Nov 1, 2019

View reviewed changes

mergify bot merged commit 27ceb2a into CodeChain-io:master Nov 1, 2019

HoOngEe deleted the feature/customized-min-fee branch November 1, 2019 05:25

HoOngEe mentioned this pull request Jan 2, 2020

Need a new RPC getting minimum fees configured by each machine CodeChain-io/foundry#56

Closed

Conversation

HoOngEe commented Oct 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

majecty left a comment

Choose a reason for hiding this comment

Uh oh!

HoOngEe commented Oct 28, 2019

Uh oh!

foriequal0 left a comment

Choose a reason for hiding this comment

Uh oh!

HoOngEe commented Oct 29, 2019

Uh oh!

foriequal0 Oct 29, 2019

Choose a reason for hiding this comment

Uh oh!

HoOngEe Oct 29, 2019

Choose a reason for hiding this comment

Uh oh!

foriequal0 Oct 29, 2019

Choose a reason for hiding this comment

Uh oh!

majecty Oct 29, 2019

Choose a reason for hiding this comment

Uh oh!

majecty Oct 29, 2019

Choose a reason for hiding this comment

Uh oh!

HoOngEe Oct 29, 2019

Choose a reason for hiding this comment

Uh oh!

HoOngEe Oct 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

majecty left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HoOngEe commented Oct 25, 2019 •

edited

Loading

HoOngEe Oct 30, 2019 •

edited

Loading