Store the peer list on the DB of a node by MSNTCS · Pull Request #1945 · CodeChain-io/codechain

MSNTCS · 2020-01-02T09:42:10Z

Storing all stable nodes that have been connected to the node in the database. It fixes #1569".

rpc/src/v1/impls/mempool.rs

network/src/p2p/mod.rs

core/src/consensus/tendermint/engine.rs

core/src/db.rs

core/src/peer_db.rs

network/src/p2p/handler.rs

majecty · 2020-01-03T06:33:35Z

Please add an issue number in the description of PR like "Fixes #1569".
Add a description in the commit message and PR description about why we need to save the peer list in the DB and what will be changed after this PR or commit.

Please use a full sentence in the description of PR and commit message.

codechain/config/mod.rs

network/src/p2p/connection/established.rs

network/src/p2p/handler.rs

network/src/lib.rs

network/src/p2p/handler.rs

MSNTCS · 2020-01-06T04:57:50Z

I tested the unpassed test( Change common Params that doesn't affect validator set) on my local machine and it passed the test. My implementation does not have any problem with this test.

sgkim126

You missed removing the address of outgoing connections.
Please check the line between 1077~1093.

core/src/db.rs

codechain/auto_self_nominate.rs

sgkim126 · 2020-01-19T14:13:13Z

@MSNTCS Would you check the commits included in this PR again?

MSNTCS · 2020-01-29T01:42:52Z

@MSNTCS Would you check the commits included in this PR again?

Sorry, for the late response. I had changed when I saw your comment. Now is only related commit.

majecty · 2020-02-05T08:32:18Z

Please run rustfmt whenever you create a commit.

majecty · 2020-02-05T08:34:38Z

Your commit messages "Update handler.rs" and "Update service.rs" does not give any meaningful information to a reader.
It seems that the reason why you created the two commits is that some code is different from Foundry's and yours. Then could you give the information in the commit message?

majecty · 2020-02-05T08:37:20Z

@MSNTCS Could you also cherry pick these commits?
IMO, you can squash them in your first commit.
CodeChain-io/foundry@e22ea52
CodeChain-io/foundry@c6dcf54
CodeChain-io/foundry@82716dd
CodeChain-io/foundry@7471a90
CodeChain-io/foundry@d530645
CodeChain-io/foundry@97b8c62

Never mind the above message. I misunderstood this PR. Sorry.

core/src/db.rs

sgkim126

LGTM.
Let's merge it after @majecty 's approval.

majecty · 2020-02-06T03:26:11Z

network/src/service.rs

 use crate::routing_table::RoutingTable;
-use crate::{p2p, Api, NetworkExtension, SocketAddr};
+use crate::{p2p, Api, ManagingPeerdb, NetworkExtension, SocketAddr};
+


Please remove this empty line.

network/src/service.rs

To reduce the burden of bootstrap nodes, codecahin needs to save the received peer list in the disk. In order to save the peer list of a node in the disk, a procedure is designed a database to store nodes that are connected to the node.

majecty

Looks good to me.

MSNTCS changed the title ~~Storing Peer List on the DB of the Node~~ Store the peer list on the DB of a node Jan 3, 2020

MSNTCS requested review from majecty and sgkim126 January 3, 2020 03:31

MSNTCS force-pushed the master branch from ddc879c to c1c5e5d Compare January 3, 2020 03:34

sgkim126 requested changes Jan 3, 2020

View reviewed changes

MSNTCS force-pushed the master branch from c1c5e5d to 9165655 Compare January 3, 2020 10:36

sgkim126 requested changes Jan 4, 2020

View reviewed changes

sgkim126 reviewed Jan 4, 2020

View reviewed changes

network/src/p2p/handler.rs Outdated Show resolved Hide resolved

sgkim126 reviewed Jan 4, 2020

View reviewed changes

network/src/p2p/handler.rs Outdated Show resolved Hide resolved

MSNTCS force-pushed the master branch 2 times, most recently from 34736c0 to d2dcaa7 Compare January 6, 2020 01:22

MSNTCS requested a review from sgkim126 January 6, 2020 04:41

MSNTCS force-pushed the master branch 6 times, most recently from f609bf6 to 730b568 Compare January 6, 2020 06:46

sgkim126 requested changes Jan 6, 2020

View reviewed changes

sgkim126 reviewed Jan 6, 2020

View reviewed changes

core/src/db.rs Outdated Show resolved Hide resolved

MSNTCS force-pushed the master branch from 730b568 to f34df1e Compare January 6, 2020 07:38

sgkim126 reviewed Jan 10, 2020

View reviewed changes

codechain/auto_self_nominate.rs Outdated Show resolved Hide resolved

MSNTCS force-pushed the master branch from d8d0270 to dbbe2aa Compare January 13, 2020 05:46

MSNTCS force-pushed the master branch 2 times, most recently from 6141594 to 9d3f1a3 Compare January 22, 2020 02:49

MSNTCS requested a review from sgkim126 January 29, 2020 01:44

MSNTCS requested a review from majecty February 5, 2020 06:08

MSNTCS force-pushed the master branch 3 times, most recently from 219506c to f0ce9b4 Compare February 5, 2020 07:29

majecty requested changes Feb 5, 2020

View reviewed changes

core/src/db.rs Outdated Show resolved Hide resolved

MSNTCS force-pushed the master branch 6 times, most recently from 6dc21fb to e40d00e Compare February 5, 2020 11:12

sgkim126 previously approved these changes Feb 6, 2020

View reviewed changes

MSNTCS requested a review from majecty February 6, 2020 02:40

majecty requested changes Feb 6, 2020

View reviewed changes

MSNTCS dismissed sgkim126’s stale review via b21c666 February 6, 2020 03:45

MSNTCS force-pushed the master branch 3 times, most recently from 1a122ff to 41a1f55 Compare February 6, 2020 04:10

Store the peer list on the DB of a node

5dd0028

To reduce the burden of bootstrap nodes, codecahin needs to save the received peer list in the disk. In order to save the peer list of a node in the disk, a procedure is designed a database to store nodes that are connected to the node.

MSNTCS force-pushed the master branch from 41a1f55 to 9d508a1 Compare February 6, 2020 04:13

Seulgi Kim added 2 commits February 6, 2020 13:14

Suggest to improve PeerDb

6cf1406

Change the type of PeerDb holder from Arc to Box

cff3543

MSNTCS force-pushed the master branch from 9d508a1 to cff3543 Compare February 6, 2020 04:15

majecty approved these changes Feb 6, 2020

View reviewed changes

MSNTCS requested a review from sgkim126 February 6, 2020 04:18

sgkim126 approved these changes Feb 6, 2020

View reviewed changes

mergify bot merged commit 4e9b29d into CodeChain-io:master Feb 6, 2020

Conversation

MSNTCS commented Jan 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

majecty commented Jan 3, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MSNTCS commented Jan 6, 2020

Uh oh!

sgkim126 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sgkim126 commented Jan 19, 2020

Uh oh!

MSNTCS commented Jan 29, 2020

Uh oh!

majecty commented Feb 5, 2020

Uh oh!

majecty commented Feb 5, 2020

Uh oh!

majecty commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sgkim126 left a comment

Choose a reason for hiding this comment

Uh oh!

majecty Feb 6, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

majecty left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MSNTCS commented Jan 2, 2020 •

edited

Loading

majecty commented Feb 5, 2020 •

edited

Loading