Make sync tests not to propagate transactions#1981
Merged
majecty merged 1 commit intoCodeChain-io:masterfrom Aug 10, 2020
Merged
Make sync tests not to propagate transactions#1981majecty merged 1 commit intoCodeChain-io:masterfrom
majecty merged 1 commit intoCodeChain-io:masterfrom
Conversation
These tests use solo consensus. To generate a block with the solo consensus, there should be a transaction. These tests send a transaction to a node to make a block. Then the node propagates the generated block to other nodes. These tests then check the other nodes whether the received the block or not. However, if the transaction is propagated before the block, these tests fail. If the transaction is propagated, other nodes will generate their own blocks. Then they will reject the block that the first node generated.
Contributor
|
So if there is no transaction, |
Author
|
@junha1 Yes it is. As far as I know, solo only generates a block when a transaction is sent. |
junha1
approved these changes
Aug 6, 2020
sgkim126
approved these changes
Aug 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current CodeChain master does not fail the tests without this commit.
However, #1979 fails the tests quite often without this PR.
These tests use solo consensus. To generate a block with the solo
consensus, there should be a transaction. These tests send a
transaction to a node to make a block. Then the node propagates the
generated block to other nodes. These tests then check the other nodes
whether the received the block or not.
However, if the transaction is propagated before the block, these
tests fail. If the transaction is propagated, other nodes will
generate their own blocks. Then they will reject the block that the
first node generated.