Merged
Conversation
sgkim126
force-pushed
the
body-downloader
branch
2 times, most recently
from
9f2b596 to
6bbc90a
Compare
sgkim126
force-pushed
the
body-downloader
branch
from
6bbc90a to
d299384
Compare
majecty
requested changes
Feb 10, 2020
Once we introduce the CloseBlock transaction, there will be no empty block.
sgkim126
force-pushed
the
body-downloader
branch
from
9389bc0 to
c044002
Compare
There are 5 states for block hashes. 1. listed, but no request sent 2. sent the request 3. received the response 4. drained from the list 5. imported on the chain Currently, these states are implicit with the combination of targets, downloading, and downloaded fields. This patch merges downloading and downloaded fields, and make the states explicit.
sgkim126
force-pushed
the
body-downloader
branch
from
c044002 to
d280a45
Compare
majecty
approved these changes
Feb 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are five states for block hashes.
Currently, these states are implicit with the combination of targets, downloading, and downloaded fields.
This patch merges downloading and downloaded fields, and make the states explicit.
There are four explicit states. The 5th state does not exist in BodyDownloader because it doesn't care about the imported blocks.