Merged
Conversation
added 5 commits
January 29, 2020 11:17
Foundry should send a self-nomination transaction before too late
Foundry should send a self-nomination transaction before the nomination ends.
Since the bob is using the auto-self-nomination, we don't need to send the self-nomination transaction manually in the test. Occasionally, the test failed because of the seq conflict with auto-selfnomination and the manual transaction.
10ms was too short.
majecty
commented
Jan 29, 2020
| let candidate_need_nomination = candidate.get_candidate(&address).unwrap(); | ||
| if candidate_need_nomination.nomination_ends_at <= current_term + NEED_NOMINATION_UNDER_TERM_LEFT { | ||
| cdebug!(ENGINE, "No need self nominate"); | ||
| if candidate_need_nomination.nomination_ends_at + NEED_NOMINATION_UNDER_TERM_LEFT <= current_term { |
Contributor
There was a problem hiding this comment.
Yes, I think it should be reversed.
The purpose of the test is testing auto-self-nomination.
MSNTCS
approved these changes
Jan 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.