Skip to content

Change constants to enumerations#136

Merged
majecty merged 3 commits intoCodeChain-io:masterfrom
sgkim126:enum
Feb 4, 2020
Merged

Change constants to enumerations#136
majecty merged 3 commits intoCodeChain-io:masterfrom
sgkim126:enum

Conversation

@sgkim126
Copy link
Contributor

@sgkim126 sgkim126 commented Feb 2, 2020

This patch changes the state item prefixes and transaction tags to enumerations to make a compiler check duplications.
Actually, it's part of #38, but implementing and testing the issues takes more time than I expected. So I pushed it separately to avoid more conflicts.

@sgkim126 sgkim126 added the refactoring Behavior does not change. Make code simple label Feb 2, 2020
@sgkim126 sgkim126 requested a review from majecty February 2, 2020 14:08
Copy link

@majecty majecty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@majecty majecty merged commit 27ef98f into CodeChain-io:master Feb 4, 2020
@sgkim126 sgkim126 deleted the enum branch March 1, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Behavior does not change. Make code simple

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants