Skip to content

Rename Action to Datagram in IBC code#161

Merged
majecty merged 1 commit intoCodeChain-io:ics-pocfrom
majecty:f/ics-poc-datagram
Feb 13, 2020
Merged

Rename Action to Datagram in IBC code#161
majecty merged 1 commit intoCodeChain-io:ics-pocfrom
majecty:f/ics-poc-datagram

Conversation

@majecty
Copy link

@majecty majecty commented Feb 12, 2020

No description provided.

@majecty majecty added the ics Interchain standard label Feb 12, 2020
@majecty majecty requested a review from junha1 February 12, 2020 10:14
@majecty majecty changed the title Make IBC KVStore use IBC data in TopLevelState Rename Action to Datagram in IBC code Feb 12, 2020

#[derive(Debug, PartialEq)]
pub enum Action {
pub enum Datagram {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All transactions related to ICS will be added here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll add all of them here.

@majecty
Copy link
Author

majecty commented Feb 13, 2020

Only one test failed because of a timeout. I"ll merge this PR.

@majecty majecty merged commit 4c4cc89 into CodeChain-io:ics-poc Feb 13, 2020
@majecty majecty deleted the f/ics-poc-datagram branch February 13, 2020 01:54
@junha1 junha1 added experiment Experimental features refactoring Behavior does not change. Make code simple labels Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experiment Experimental features ics Interchain standard refactoring Behavior does not change. Make code simple

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants