Implement connOpenTry datagram in the ICS connection spec#166
Merged
majecty merged 1 commit intoCodeChain-io:ics-pocfrom Feb 17, 2020
Merged
Implement connOpenTry datagram in the ICS connection spec#166majecty merged 1 commit intoCodeChain-io:ics-pocfrom
majecty merged 1 commit intoCodeChain-io:ics-pocfrom
Conversation
majecty
force-pushed
the
f/ics-conn-open-try
branch
2 times, most recently
from
a4b6f70 to
99b0513
Compare
majecty
changed the title
6 tasks
I omit vector commitment and light client part. I will fill the part after we merge them in the PoC branch.
majecty
force-pushed
the
f/ics-conn-open-try
branch
from
99b0513 to
db33a78
Compare
junha1
reviewed
Feb 17, 2020
| consensus_height, | ||
| } => { | ||
| s.begin_list(10); | ||
| s.append(&DatagramTag::ConnOpenTry) |
Contributor
There was a problem hiding this comment.
I think we really need to improve macro to support enum and tuple someday...
junha1
reviewed
Feb 17, 2020
junha1
approved these changes
Feb 17, 2020
junha1
reviewed
Feb 17, 2020
| fn verify_connection_state( | ||
| &self, | ||
| ctx: &mut dyn ibc::Context, | ||
| connection: &ConnectionEnd, |
Contributor
There was a problem hiding this comment.
Could you explain the meaning of this argument? @majecty (compared to connection_end)
Author
There was a problem hiding this comment.
I checked the spec. The spec is not using it. Please ignore the argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.