Report double votes in commit messages.#181
Merged
byeongjee merged 3 commits intoCodeChain-io:masterfrom Feb 18, 2020
Merged
Conversation
added 2 commits
February 18, 2020 14:49
Some DoubleVote type variables should be renamed for consistency.
byeongjee
force-pushed
the
fix.double.vote.bug
branch
from
820d42d to
e4ce9c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a Tendermint worker detects double votes in commit messages, but does not report them. I think this is a bug, so I changed the behavior.