Impement queryConnection and queryClientConnections#195
Merged
majecty merged 4 commits intoCodeChain-io:ics-pocfrom Feb 25, 2020
Merged
Impement queryConnection and queryClientConnections#195majecty merged 4 commits intoCodeChain-io:ics-pocfrom
majecty merged 4 commits intoCodeChain-io:ics-pocfrom
Conversation
6 tasks
majecty
force-pushed
the
f/ics-conn-queries
branch
2 times, most recently
from
915e96d to
c1e9ed6
Compare
majecty
changed the title
junha1
reviewed
Feb 25, 2020
| Some(connection_end) | ||
| } | ||
|
|
||
| pub fn query_client_connections(&self, identifier: &str) -> ConnectionIdentifiersInClient { |
Contributor
There was a problem hiding this comment.
Let's make all Manager's query functions to be private.
majecty
force-pushed
the
f/ics-conn-queries
branch
from
c1e9ed6 to
d007b85
Compare
junha1
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I left the proof part. I'll update this PR after Junha finish #196Now, I'm ready for review.