Remove the score in the foundry

[somniumism]

The tests were not updated when we changed the BlockSynMessage.
We removed the unnecessary score from the foundry and its tests.

resolves #208

[somniumism]

There are currently many test failures caused by time out as follows:

1) invalid block propagation 0
       "before each" hook for "OnChain invalid parent block propagation test":
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/somniumism/Project/PR/foundry/test/src/e2e.long/invalidBlockPropagation0.test.ts)
      at listOnTimeout (internal/timers.js:549:17)
      at processTimers (internal/timers.js:492:7)

[somniumism]

I added @junha1 as a reviewer. He knows more about the foundry test and its structure than I do, so he can find a problem I can't find. Please check it carefully. : )))

[junha1]

In my experience, those failures are not just timeouts. You must fix them all, and make sure they all passed in local first.

[somniumism]

I found the cause of test failure. I separated the commit that causes it: Error: Remove the score from IStatus
The cause is related to SyncMessage. When this commit is applied, the following error occurs:

  invalid block propagation 0
Error: Expected 32 byte hexstring for creating H256 but found ""
    at new H256 (/Users/somniumism/Project/PR/foundry/test/node_modules/codechain-primitives/src/value/H256.ts:52:19)
    at Function.fromBytes (/Users/somniumism/Project/PR/foundry/test/src/helper/mock/blockSyncMessage.ts:66:30)
    at P2pLayer.onExtensionMessage (/Users/somniumism/Project/PR/foundry/test/src/helper/mock/p2pLayer.ts:326:55)
    at P2pLayer.onSignedMessage (/Users/somniumism/Project/PR/foundry/test/src/helper/mock/p2pLayer.ts:310:22)
    at Socket.<anonymous> (/Users/somniumism/Project/PR/foundry/test/src/helper/mock/p2pLayer.ts:138:46)
    at Socket.emit (events.js:321:20)
    at addChunk (_stream_readable.js:297:12)
    at readableAddChunk (_stream_readable.js:273:9)
    at Socket.Readable.push (_stream_readable.js:214:10)
    at TCP.onStreamRead (internal/stream_base_commons.js:186:23)
    1) "before each" hook for "OnChain invalid parent block propagation test"
    2) "after each" hook for "OnChain invalid parent block propagation test"

The error is related to the change in this code. I definitely removed totalScore from IStatus, so msg should contain only two elements. But it seems that there is still a totalScore in its 0th element. Once this error has been resolved, the work of removing the score from the foundry is finished.

@majecty Could you check what I did wrong and give me some advice?

[somniumism]

There are 3 commits in this PR. I checked that the e2e test works successfully on Remove the score in the test.

[somniumism]

It seems to be related to exchanging any data in the p2p layer. msg contains totalScore, bestHash, and genesisHash. I deleted totalScore, but I think there is still totalScore in the data exchanged. I don't know what data is exchanged or what it is.

I checked what the msg contains using console.log() as follows:

        if (msgId === MessageType.MESSAGE_ID_STATUS) {
            Emitter.emit("status");
            const msg = decodedmsg[1];
            console.log(msg[0]); //
            console.log(msg[1]); //
            console.log(msg[2]); //
            const totalScore = new U256(
                parseInt(msg[0].toString("hex"), 16) || 0
            );
            const bestHash = new H256(msg[1].toString("hex"));

The results are as follows:
Case 1) The commit: Remove the score in the test
(That is the case where the test works well)

<Buffer >
<Buffer 5d ef 65 01 00 3b 7d b7 4d 4b ca 8c 76 1a 37 35 ad c9 dc 22 69 39 88 5d 9f e1 d0 58 78 3b 29 79>
<Buffer 5d ef 65 01 00 3b 7d b7 4d 4b ca 8c 76 1a 37 35 ad c9 dc 22 69 39 88 5d 9f e1 d0 58 78 3b 29 79>

case 2) The commit: [Error] Remove the score from IStatus
(This is the case where a test failure occurs)

<Buffer >
<Buffer 5d ef 65 01 00 3b 7d b7 4d 4b ca 8c 76 1a 37 35 ad c9 dc 22 69 39 88 5d 9f e1 d0 58 78 3b 29 79>
<Buffer 5d ef 65 01 00 3b 7d b7 4d 4b ca 8c 76 1a 37 35 ad c9 dc 22 69 39 88 5d 9f e1 d0 58 78 3b 29 79>

I certainly did remove the total score in the second but in both cases the same result.

[junha1]

@somniumism Need rebase

[somniumism]

@junha1 I rebased it onto master.

[junha1]

This commit is very sensitive to e2e tests, so please merge it after it passes CI.

[junha1]

@somniumism Could you check the error?