Use ctypes::Header instead of encoded::Header in HeaderDownloader#325
Merged
sgkim126 merged 4 commits intoCodeChain-io:masterfrom Apr 14, 2020
Merged
Use ctypes::Header instead of encoded::Header in HeaderDownloader#325sgkim126 merged 4 commits intoCodeChain-io:masterfrom
ctypes::Header instead of encoded::Header in HeaderDownloader#325sgkim126 merged 4 commits intoCodeChain-io:masterfrom
Conversation
added 2 commits
April 13, 2020 17:16
The purpose of the encoded type is to read a few fields from binary data when we don't want to full deserialize it. In the header sync, we already deserialized the whole struct in the verification process. We don't need to encoded Header when we have ctypes::Header.
sgkim126
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of the encoded type is to read a few fields from binary data when we don't want to full deserialize it. In the header sync, we already deserialized the whole struct in the verification process. We don't need to encoded Header when we have
ctypes::Header.