Remove unnecessary serialize/deserialize while calling import_header#331
Merged
majecty merged 2 commits intoCodeChain-io:masterfrom Apr 16, 2020
Merged
Remove unnecessary serialize/deserialize while calling import_header#331majecty merged 2 commits intoCodeChain-io:masterfrom
majecty merged 2 commits intoCodeChain-io:masterfrom
Conversation
sgkim126
approved these changes
Apr 16, 2020
Contributor
|
@majecty I think it's good to move the value if there is no overhead. |
Author
|
Since the failed tests are "discovery5 nodes" and "connect 100 nodes", I merged this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sgkim126 I changed import_trusted_header to receive
Headerinstead of&Header. When importing a header, I feel moving a header is more natural than borrowing the header. However, I'm not confident. Do you have any idea?