Merged
Conversation
added 4 commits
April 16, 2020 17:57
Client::import_header function receives a header that is not verified. Importer::import_headers assumes that received headers are verified. To reduce misunderstanding, I renamed the function.
Previously we called a block received by snapshot sync as "bootstrap block". Now we're calling it "floating block".
The name `import_closed_block` does not give enough context.
import_trusted_{header, block} are called by snapshot code. They can
import header and block that don't have parents. We need a better name
for them.
sgkim126
approved these changes
Apr 16, 2020
Author
|
Since the failed test is "connect 100 nodes", I'll merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.