Simplify miner, client and block.#333
Merged
majecty merged 4 commits intoCodeChain-io:masterfrom Apr 20, 2020
Merged
Conversation
added 3 commits
April 16, 2020 20:48
The close_impl was extracted because close and close_and_lock have duplicate code. Now this is not necessary because close_and_lock is removed.
The h is always None.
Currently, AccountProvider in the miner is optional to support unit tests who cannot use the account provider which uses the permanent storage. This commit makes the miner uses memory back-end AccountProvider for test.
Contributor
Author
|
The linux build fails, but the same test successes on osx. I think it's the problem of Travis. |
majecty
approved these changes
Apr 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring is done to implement #324. But, because the PR takes more time than expected, I extracted the refactoring commits.