Fix header RLP encoding in mock code#376
Merged
majecty merged 5 commits intoCodeChain-io:masterfrom May 12, 2020
Merged
Conversation
majecty
force-pushed
the
f/fix-mock-header-2
branch
from
8e298fb to
274d1e1
Compare
sgkim126
previously approved these changes
May 9, 2020
Contributor
|
LGTM. Let's remove the |
majecty
force-pushed
the
f/fix-mock-header-2
branch
3 times, most recently
from
aa8cc43 to
80a9e3e
Compare
added 5 commits
May 11, 2020 14:03
The seal is an array of any RLP data. Wrapping them with Buffer makes invalid RLP encoding.
Since Header has a cache of its hash using RefCell, the existence of the cache changes the compare result.
majecty
force-pushed
the
f/fix-mock-header-2
branch
from
80a9e3e to
1c03372
Compare
Author
|
@sgkim126 I fixed some test cases. |
majecty
pushed a commit
to majecty/foundry
that referenced
this pull request
May 11, 2020
Change mock's Header::default function to static function Change seal serialize code in mock The seal is an array of any RLP data. Wrapping them with Buffer makes invalid RLP encoding. Add Header RLP encoding test in mock Remove PartialEq derive from Header and Block Since Header has a cache of its hash using RefCell, the existence of the cache changes the compare result. Add a hint comment that helps programmer to manage tests
sgkim126
approved these changes
May 12, 2020
Author
|
The failed test is "connect 100 nodes". I'll merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #369