Make the client hold the miner directly#410
Merged
majecty merged 2 commits intoCodeChain-io:masterfrom Jun 8, 2020
Merged
Conversation
Currently, the client access the miner through the importer. It's better to give a method to access the miner directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the client access the miner through the importer. It's better to give a method to access the miner directly.
It closes #44. The issue suggests moving the miner to the client. However, because the importer holds the arc of the miner, we can make both of the importer and the client hold the miner. I think it's better than moving because the importer also needs the miner.