Skip to content

Execute self-nomination transactions on a new thread#98

Merged
majecty merged 3 commits intoCodeChain-io:masterfrom
MSNTCS:master
Jan 28, 2020
Merged

Execute self-nomination transactions on a new thread#98
majecty merged 3 commits intoCodeChain-io:masterfrom
MSNTCS:master

Conversation

@MSNTCS
Copy link
Contributor

@MSNTCS MSNTCS commented Jan 13, 2020 •
edited
Loading

Currently, we have a tool written in TypeScript to run auto-self-nominate.
In this new patch, codechain is able to run auto-self-nominate in a different
thread. it fixes #57.

@MSNTCS MSNTCS requested a review from majecty January 13, 2020 05:23
@majecty
Copy link

majecty commented Jan 13, 2020

Please fix your commit message. "Currently, we have a tool written in TypeScript to run run auto-self-nominate." -> "Currently, we have a tool written in TypeScript to run auto-self-nominate."

@majecty
Copy link

majecty commented Jan 13, 2020

Your code creates a thread, not a process. Please change your commit message and PR description.

@MSNTCS
Copy link
Contributor Author

MSNTCS commented Jan 13, 2020

Your code creates a thread, not a process. Please change your commit message and PR description.

Sure, I will wait for your review and then apply changes.

majecty
majecty requested changes Jan 13, 2020
View reviewed changes
majecty
majecty requested changes Jan 14, 2020
View reviewed changes
majecty
majecty requested changes Jan 15, 2020
View reviewed changes
Copy link

@majecty majecty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an e2e test to test this feature!

@majecty
Copy link

majecty commented Jan 20, 2020

@MSNTCS Please do not include issue number in the commit message.
It makes unnecessary messages in the issue. Every time you update your commit, GitHub will add a new message to the issue.
You can add issue number in the PR, but not in the commit messages.

@MSNTCS
Copy link
Contributor Author

MSNTCS commented Jan 20, 2020

@MSNTCS Please do not include issue number in the commit message.
It makes unnecessary messages in the issue. Every time you update your commit, GitHub will add a new message to the issue.
You can add issue number in the PR, but not in the commit messages.

Thanks, I will take care of it.

majecty
majecty requested changes Jan 20, 2020
View reviewed changes
majecty
majecty previously approved these changes Jan 20, 2020
View reviewed changes
@majecty
Copy link

majecty commented Jan 20, 2020

It looks good to me. I'll merge this PR after CI completes the tests.

majecty
majecty requested changes Jan 20, 2020
View reviewed changes
majecty
majecty previously approved these changes Jan 20, 2020
View reviewed changes
Copy link

@majecty majecty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I'll merge this PR after CI completes the tests.

@majecty
Copy link

majecty commented Jan 22, 2020 •
edited
Loading

@MSNTCS The tests you added failed. Are they working on your local machine?

@majecty
Copy link

majecty commented Jan 23, 2020

@MSNTCS Please update "foundry/config/presets/config.prod.toml" also.

@MSNTCS MSNTCS changed the title Execute self-nomination transactions on a seprate process Execute self-nomination transactions on a new thread Jan 28, 2020
MSNTCS and others added 3 commits January 28, 2020 16:12
@MSNTCS
Execute self-nomination transactions on a new thread
5860634 
Currently, we have a tool written in TypeScript to run auto-self-nominate. In
this new patch, codechain is able to run auto-self-nominate in a different
thread. In order to test the functionality of auto-self-nominate, a new
`selfnomination` test is added in `e2e.dynval/2/selfnomination.test.ts`.
@MSNTCS
Change some functions due to the clippy restrictions
0a85a5c 
Implementing the auto self-nomination thread led to some clippy problems which
we had to change some part of `consensus/stake`.
Merge branch 'master' into master
3ed01cf
@majecty majecty merged commit 88fbd4d into CodeChain-io:master Jan 28, 2020
@majecty majecty mentioned this pull request Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majecty majecty majecty left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Execute self-nomination transactions automatically

2 participants

@MSNTCS @majecty