Skip to content

Conversation

@D3-LucaPiombino
Copy link

@D3-LucaPiombino D3-LucaPiombino commented Mar 30, 2025

Summary of the Pull Request

  • Fix: Ensure bash EOL is LF and not CRLF
  • Fix: Apply fixes reported by shellcheck
  • Fix/Enhance: Check if target exists before creating a directory. This should not be necessary, but i had some random occourrence where the installation was failing because directories/mounts already exists and this seems to have solved the issue.
  • Enhance: Add some volume mapping to cache known build artifacts to speed up local builds (build.ps1)

- Fix: Ensure bash EOL is `LF` and not `CRLF`
- Fix Apply fixes reported by shellcheck
- Check if target exists before creating a directory.
  This should not be necessary, but i had some random occourrence where
  the installation was failing because directories/mounts already exists  and
  this seems to have solved the issue.
- Add some volume mapping to cache known build artifacts to speed up local builds (`build.ps1`)
@D3-LucaPiombino D3-LucaPiombino added the enhancement New feature or request label Mar 30, 2025
@D3-LucaPiombino D3-LucaPiombino changed the title Bash/ps1 script improvements/fixes Bash/ps1 script enhancements/fixes Mar 30, 2025
@D3-LucaPiombino D3-LucaPiombino changed the title Bash/ps1 script enhancements/fixes bash/ps1 scripts enhancements/fixes Mar 30, 2025
@D3-LucaPiombino D3-LucaPiombino merged commit fa5bd10 into main Mar 30, 2025
3 checks passed
@D3-LucaPiombino D3-LucaPiombino deleted the feat/improve_bash_and_ps1_scripts branch March 30, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants