Fix: installer fail with NRE when DnsMode is Wsl
#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking for `Name == "vEthernet (WSL)"` does not work on app store based WSL installations as the adapter is named `vEthernet (WSL (Hyper-V firewall))` Also configure the json serializer to support serializing/deserializing enum (e.g. `DnsMode`) found in configuration as names instead of only as numbers.
D3-LucaPiombino
changed the title
AutoWsl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Looking for
Name == "vEthernet (WSL)"does not work on app store based WSL installations because the adapter is namedvEthernet (WSL (Hyper-V firewall)).This also configure the json serializer to support serializing/deserializing enum (e.g.
DnsMode) found in configuration as names instead of only as numbers.