Fix setup on boxes app store based WSL install #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the configuration manifest to use the "new" way to install/update WSL (Windows 10 version 2004 Build >= 19041 or Windows 11) instead of installing it manually via windows features + the msi (`wsl_update_x64.msi`) > Source: https://learn.microsoft.com/en-us/windows/wsl/install#install-wsl-command Unfortunately we need to make this optional as it's not trivial to handle all possible use cases correctly. Note that this will only work if the user either - Did not install WSL yet - Already installed WSL from the app store - Already installed WSL using `wsl.exe --install ...` It will fail if the user already installed WSL using the "inbox" way (enabled through windows features). In this case the wsl.exe CLI will not have the --no-distribution and --web-download parameters. If the user experience issues, it can uncheck the WSL update steps and then can update/install WSL himself without being blocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The installer will fail on windows boxes where WSL has been installed via the app store/OOB and not as a windows features.
This is because the Linux kernel is placed in a different location for ap store installations and the
wsl_update_x64.msiinstaller will not recognize that WSL is installed.This update the configuration manifest to use the "new" way to install/update WSL (Windows 10 version 2004 Build >= 19041 or Windows 11) instead of installing it manually via windows features + the msi (
wsl_update_x64.msi)Detailed Description of the Pull Request / Additional comments
Unfortunately we need to make this optional as it's not trivial to handle all possible use cases correctly.
Note that this will only work if the user either
wsl.exe --install ...It will fail if the user already installed WSL using the "inbox" way (enabled through windows features).
In this case the wsl.exe CLI will not have the --no-distribution and --web-download parameters.
If the user experience issues, it can uncheck the WSL update steps and then can update/install WSL himself without being blocked.