Skip to content

Conversation

@leiyu-bytedance
Copy link

Previously the systemd units were not installed and it depends on the bitbake recipe (in meta-openembedded) to install the service only.

Update the meson.build and install all the units. The bitbake recipe will need to be updated to add missing units to SYSTEMD_SERVICE:${PN}.

Previously the systemd units were not installed and it depends on the
bitbake recipe (in meta-openembedded) to install the service only.

Update the meson.build and install all the units. The bitbake recipe
will need to be updated to add missing units to `SYSTEMD_SERVICE:${PN}`.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
@jk-ozlabs
Copy link
Member

So these units were a bit of a draft in their current state, and don't (yet!) mean to be a fully-formed system MCTP config.

Does this mean they're working for your environment? Any changes in the infrastructure around these that you would propose?

@leiyu-bytedance
Copy link
Author

Yes, to integrate the recipe into BMC and make it useful, we need all the units to be installed.
So in the bitbake recipe, additional changes are needed as well:

SYSTEMD_SERVICE:${PN}:append = " \
    mctp.target \
    mctp-local.target \
"

@jk-ozlabs
Copy link
Member

OK, been thinking about this one a bit. The installation of targets & config data is really a distro-specific thing; we can't really assume that the systemd units have the correct dependencies, are properly integrated with other units, or even that systemd is available.

Given that installation should be managed by the distro, I'd prefer that we don't install them in the meson targets.

I'll close for now, but am happy to continue discussion if you have counterpoints. Feel free to re-open.

@jk-ozlabs jk-ozlabs closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants