mctp-bench: Add a utility tool to send/receive messages and display throughput #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkj
reviewed
Dec 19, 2024
Member
mkj
left a comment
mkj
left a comment
There was a problem hiding this comment.
Looks good, thanks. Noted a few small things
…hroughput A utility tool that implements a sender and receiver to benchmark mctp throughput. This is split into a sender command and a receive command in the same executable. The receive command waits for incoming messages, notifies the user of first message received and then prints out measured throughput periodically. Example usage: mctp-bench recv The sender command sends messages continously, the size of which can be set by the user, defaulting to 8 bytes. Example usage: mctp-bench send len 1000 eid 8 Signed-off-by: Timon Liu <timon@codeconstruct.com.au>
Timon-L
force-pushed
the
pr/mctp-bench
branch
from
3114937 to
ac02817
Compare
Contributor
Author
|
Thanks for the feedback, applied the suggested changes and added allocate tag function to check if SIOCMCTPALLOCTAG2 or SIOCMCTPALLOCTAG exists for the sender to use. |
mkj
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A utility tool that implements a sender and receiver to benchmark mctp throughput. This is split into a sender command and a receive command in the same executable.
The receive command waits for incoming messages, notifies the user of first message received and then prints out measured throughput periodically.
Example usage:
mctp-bench recv
The sender command sends messages continously, the size of which can be set by the user, defaulting to 8 bytes.
Example usage:
mctp-bench send len 1000 eid 8