Skip to content

Conversation

@CodeDredd
Copy link
Owner

πŸ”— Linked issue

related #1818

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The get mutators & casts were still wrong for updated data. Now there is a design change for model properties who have casts or mutators. The performance will be a bit slower in some edge cases because shadow props are now introduced.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.67%. Comparing base (76eb4a5) to head (99df5da).

Files Patch % Lines
packages/pinia-orm/src/model/Model.ts 96.77% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1824   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          87       87           
  Lines        5900     5923   +23     
  Branches      500      505    +5     
=======================================
+ Hits         5881     5904   +23     
- Misses         16       17    +1     
+ Partials        3        2    -1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants