Skip to content

refactor(pinia-orm): createORM() had wrong type #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeDredd merged 2 commits into from
May 5, 2024
Merged

refactor(pinia-orm): createORM() had wrong type #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8896cc1
refactor(pinia-orm): createORM() had wrong type
CodeDredd May 5, 2024
fa3d186
refactor(pinia-orm): linting
CodeDredd May 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pinia-orm/.eslintcache
View file
Open in desktop

Large diffs are not rendered by default.

15 changes: 9 additions & 6 deletions packages/pinia-orm/src/store/Store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { PiniaPlugin } from 'pinia'
import type { WeakCache } from '../cache/WeakCache'
import type { Model } from '../model/Model'
import { CONFIG_DEFAULTS, config } from './Config'
Expand Down Expand Up @@ -33,14 +34,16 @@ export interface CreatePiniaOrm {
/**
* Install Pinia ORM to the store.
*/
export function createORM (options?: InstallOptions) {
export function createORM (options?: InstallOptions): PiniaPlugin {
config.model = { ...CONFIG_DEFAULTS.model, ...options?.model }
config.cache = options?.cache === false ? false : { ...CONFIG_DEFAULTS.cache, ...(options?.cache !== true && options?.cache) }
const orm = {
use (plugin: PiniaOrmPlugin) {
const orm = () => {
function use (plugin: PiniaOrmPlugin) {
plugins.push(plugin)
return this
},
}
return {
use,
}
}
return () => orm
return orm
}