fix(pinia-orm): Typings of useRepo with Repository are broken
#1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1848 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 88 88
Lines 6032 6032
Branches 512 512
=======================================
Hits 6018 6018
Misses 12 12
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Merged
daniser
reviewed
May 13, 2024
| import { registerPlugins } from '../store/Plugins' | ||
|
|
||
| export function useRepo<R extends Repository> ( | ||
| export function useRepo<R extends Repository<any>> ( |
Contributor
There was a problem hiding this comment.
I don't get why it stopped working in the first place... Is it somehow related to the attribute autocompletion?
Owner
Author
There was a problem hiding this comment.
Correctly. This PR changed some internall behaviour for passing the Model type to where and with.
It now comes to my mind....i don't know if autocomplete is now working correctly with custom Repo. I have to check that.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
closes #1847
❓ Type of change
📚 Description
📝 Checklist