Skip to content

Conversation

@dev1437
Copy link
Contributor

@dev1437 dev1437 commented Jan 10, 2023

πŸ”— Linked issue

closes #1759 , closes #1795, related #1766

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Allows for autocompletion of attributes for certain functions.
Also enables type checking on where.
e.g. when specifying the field for where, the IDE can provide a list of the attributes on the model.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Probably a lot of clean up to be done, but I'll only do that if this is seriously considered to be merged.

@CodeDredd
Copy link
Owner

CodeDredd commented Jan 10, 2023

Awesome feature. πŸ’˜ ... seems you still have some type errors. If it works then of course it will be merged

@dev1437
Copy link
Contributor Author

dev1437 commented Jan 11, 2023

Yes, very PoC atm, but will work those down πŸ˜„

@0x00A1FA 0x00A1FA mentioned this pull request Mar 15, 2023
3 tasks
CodeDredd added 6 commits May 5, 2024 22:16
…bute-autocompletion

# Conflicts:
#	packages/pinia-orm/src/model/Model.ts
#	packages/pinia-orm/src/query/Query.ts
#	packages/pinia-orm/src/repository/Repository.ts
…ute-autocompletion

# Conflicts:
#	packages/pinia-orm/.eslintcache
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 99.70%. Comparing base (bbf7a93) to head (43b1169).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #816   +/-   ##
=======================================
  Coverage   99.69%   99.70%           
=======================================
  Files          87       88    +1     
  Lines        5959     6001   +42     
  Branches      510      510           
=======================================
+ Hits         5941     5983   +42     
  Misses         14       14           
  Partials        4        4           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants