-
-
Notifications
You must be signed in to change notification settings - Fork 43
feat: Attribute autocompletion in where and with #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Awesome feature. π ... seems you still have some type errors. If it works then of course it will be merged |
Contributor
Author
|
Yes, very PoC atm, but will work those down π |
β¦bute-autocompletion # Conflicts: # packages/pinia-orm/src/model/Model.ts # packages/pinia-orm/src/query/Query.ts # packages/pinia-orm/src/repository/Repository.ts
β¦ute-autocompletion # Conflicts: # packages/pinia-orm/.eslintcache
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
=======================================
Coverage 99.69% 99.70%
=======================================
Files 87 88 +1
Lines 5959 6001 +42
Branches 510 510
=======================================
+ Hits 5941 5983 +42
Misses 14 14
Partials 4 4 β View full report in Codecov by Sentry. |
1 task
This was referenced May 6, 2024
Merged
This was referenced May 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
closes #1759 , closes #1795, related #1766
β Type of change
π Description
Allows for autocompletion of attributes for certain functions.
Also enables type checking on
where.e.g. when specifying the field for
where, the IDE can provide a list of the attributes on the model.π Checklist
Probably a lot of clean up to be done, but I'll only do that if this is seriously considered to be merged.