Skip to content

Conversation

@austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Mar 13, 2023

Description

Refactored open quickly overlay UI to match designs more closely.

Note: I had to change how our text view was setting editable. If this was false it would simply use a disabled modifier on the text view. This did prevent editing however it also disabled scrolling as well. So in https://github.com/CodeEditApp/CodeEditTextView/pull/161 I am adding isEditable, a variable used by STTextView, in CodeEditTextView used for this very purpose.

Related Issues

Prerequisites

https://github.com/CodeEditApp/CodeEditTextView/pull/161 needs to be merged before this is merged.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Coming soon.

@austincondiff austincondiff marked this pull request as draft March 13, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Open Quickly Overlay - The vertical separator should be the same color as the horizontal separator

1 participant