Skip to content

fix(AccountsSettingsDetailsView): Fix Delete Account button (#1245) #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matthijseikelenboom merged 4 commits into from
Apr 29, 2023
Merged

fix(AccountsSettingsDetailsView): Fix Delete Account button (#1245) #1248

matthijseikelenboom merged 4 commits into from
Apr 29, 2023

Conversation

@Qubik65536
Copy link
Contributor

@Qubik65536 Qubik65536 commented Apr 28, 2023 •
edited
Loading

Description

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

2023-04-27.23-07-01.mov

@austincondiff austincondiff self-requested a review April 28, 2023 03:18
austincondiff
austincondiff requested changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! From your video, it doesn't look like it redirects the user back to the accounts list after account deletion. Can you make sure this happens please?

@Qubik65536
Copy link
Contributor Author

Qubik65536 commented Apr 28, 2023

From your video, it doesn't look like it redirects the user back to the accounts list after account deletion. Can you make sure this happens please?

I'll look into it

@Qubik65536
Copy link
Contributor Author

Qubik65536 commented Apr 28, 2023

New effect:

2023-04-27.23-24-40.mov

austincondiff
austincondiff previously approved these changes Apr 28, 2023
View reviewed changes
@Qubik65536
refactor(AccountsSettingsDetailsView): Use dismiss instead of depre…
3ab495e 
…cated PresentationMode

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
@Qubik65536
Copy link
Contributor Author

Qubik65536 commented Apr 28, 2023

Sorry, PresentationMode is deprecated, I changed it.

@matthijseikelenboom matthijseikelenboom merged commit e39baba into CodeEditApp:main Apr 29, 2023
@Qubik65536 Qubik65536 deleted the fix-delete-account branch April 29, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@austincondiff austincondiff austincondiff approved these changes

@matthijseikelenboom matthijseikelenboom matthijseikelenboom approved these changes

@0xWDG 0xWDG Awaiting requested review from 0xWDG

@lukepistrol lukepistrol Awaiting requested review from lukepistrol

@KaiTheRedNinja KaiTheRedNinja Awaiting requested review from KaiTheRedNinja

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐞 Delete Account button does not work in Accounts Settings

3 participants

@Qubik65536 @austincondiff @matthijseikelenboom