Performance improvements for settings #1250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where changing settings could be laggy.
The
@AppSettingsproperty wrapper has a new initializer, which accepts a keypath to a property in theSettingsDatastruct. With this, a view will only observe that specific part of the settings struct, resulting in less view updates when a setting has changed. This will hopefully fix the performance issues.Related Issues
#1247
Checklist
Additional Context
Instead of writing this...
...you now need to get each setting separately.
Or, if you want to observe a whole subpart of settings you can use...
...which can ease the boilerplate a bit. However, the view will be updated on every change in the text editing settings, so it should be done with care.
The old initializer will display a warning...
