New tabs after current focused tab#1704

[Shivam-Parekh]

Description

Fixed issue where new tabs opened at the end of all opened files instead of next to currently selected file.

Within the open tab function, found the currently selected tab and appended the file to be opened in the next index.

Related Issues

• 🐞 New tabs always open at the end #1704

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

[austincondiff]

Nice work!

[Shivam-Parekh]

Hey guys. I found an issue in this PR. When you open up a side window with a file and attempt to close that side window, it throws an exception. It occurs because the guard portion returns without completing the rest of the function. (The history and openfile portion). I'm new to the repo(open source in general) so I don't know what the right steps to take are.

[Wouter01]

Instead of using a guard, you could use an if let:

if let selectedTab, let currentIndex = tabs.firstIndex(of: selectedTab) {
    tabs.insert(item, at: tabs.index(after: currentIndex)
} else {
    tabs.append(item)
}