File Icon Type setting reflects immediately #1765 #1773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
previously approved these changes
Jun 23, 2024
Collaborator
austincondiff
left a comment
austincondiff
left a comment
There was a problem hiding this comment.
Keep up the good work 👍
austincondiff
requested review from
FastestMolasses,
bombardier200,
thecoolwinter and
tom-ludwig
FastestMolasses
previously approved these changes
Jun 23, 2024
tom-ludwig
previously approved these changes
Jun 23, 2024
tom-ludwig
dismissed stale reviews from FastestMolasses, austincondiff, and themself
via
25d8d76
tom-ludwig
approved these changes
Jun 23, 2024
FastestMolasses
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
File icons were not reflected immediately when changed from the settings.
on willSet for iconColor I only reload the outlineView
Related Issues
#1765
Checklist
Screenshots