Skip to content

Localized Settings panel #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukepistrol merged 6 commits into from
Mar 18, 2022
Merged

Localized Settings panel #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea0b407
Added global settings for color/monochrome style on file icons
Mar 18, 2022
699a7a0
Merge branch 'main' of https://github.com/lukepistrol/CodeEdit
Mar 18, 2022
d306a0b
Added global settings for color/monochrome style on file icons
Mar 18, 2022
972d683
Merge branch 'CodeEditApp:main' into main
Mar 18, 2022
7d90932
Merge branch 'main' of https://github.com/lukepistrol/CodeEdit
Mar 18, 2022
0eb7433
Localized Settings panel
Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions CodeEdit/Localization/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,20 @@
"Hello, world!"="Hello, world!";

// Settings - General Tab
"General"="General";

// Settings - File Icon Style
"File Icon Style"="File Icon Style";
"Color"="Color";
"Monochrome"="Monochrome";

// Settings - Appearance
"Appearance"="Appearance";
"System"="System";
"Light"="Light";
"Dark"="Dark";

// Settings Reopen Behavior
"Reopen Behavior"="Reopen Behavior";
"Open Panel"="Open Panel";
"New Document"="New Document";
20 changes: 10 additions & 10 deletions CodeEdit/Settings/GeneralSettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,30 +16,30 @@ struct GeneralSettingsView: View {

var body: some View {
Form {
Picker("Appearance", selection: $appearance) {
Text("System")
Picker("Appearance".localized(), selection: $appearance) {
Text("System".localized())
.tag(Appearances.system)
Divider()
Text("Light")
Text("Light".localized())
.tag(Appearances.light)
Text("Dark")
Text("Dark".localized())
.tag(Appearances.dark)
}
.onChange(of: appearance) { tag in
tag.applyAppearance()
}

Picker("File Icon Style", selection: $fileIconStyle) {
Text("Color")
Picker("File Icon Style".localized(), selection: $fileIconStyle) {
Text("Color".localized())
.tag(FileIconStyle.color)
Text("Monochrome")
Text("Monochrome".localized())
.tag(FileIconStyle.monochrome)
}

Picker("Reopen Behavior", selection: $reopenBehavior) {
Text("Open Panel")
Picker("Reopen Behavior".localized(), selection: $reopenBehavior) {
Text("Open Panel".localized())
.tag(ReopenBehavior.openPanel)
Text("New Document")
Text("New Document".localized())
.tag(ReopenBehavior.newDocument)
}
}
Expand Down
2 changes: 1 addition & 1 deletion CodeEdit/Settings/SettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ struct SettingsView: View {
TabView {
GeneralSettingsView()
.tabItem {
Label("General", systemImage: "gearshape")
Label("General".localized(), systemImage: "gearshape")
}
}
.padding()
Expand Down