Coach groups UI + lesson group selection (group_ids)#60
Open
sahilkashyap64 wants to merge 9 commits into
Open
Conversation
✅ Deploy Preview for thunderous-muffin-603a62 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Redesign LessonInvitePanel for mobile-first invite UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
getCoachPlayerGroups,getCoachPlayerGroupById,createCoachPlayerGroup,updateCoachPlayerGroup, anddeleteCoachPlayerGroupinsrc/services/coach.js.GroupList,GroupForm,GroupPicker,groupUtils, andCoachGroupsSection(files undersrc/components/groupsandsrc/components/dashboard/sections) plus acoachGroupstypedef insrc/types/coachGroups.js.src/App.jsxwith user-friendly API error mapping, optimistic refresh, and exposegroups*props toDashboardPage.CreateLessonModalto includeGroupPicker, addinggroupIdsto lesson drafts, sendinggroup_idsin the schedule payload, deduping existing players, and validating private-lesson selection using utilities insrc/utils/lessonGroupSelection.js.Testing
npm test, including new testssrc/utils/__tests__/lessonGroupSelection.test.js, and all tests passed (5/5).npm run buildsuccessfully.Codex Task