Unify coach requests list and patch actions in Notifications#64
Open
sahilkashyap64 wants to merge 4 commits into
Open
Unify coach requests list and patch actions in Notifications#64sahilkashyap64 wants to merge 4 commits into
sahilkashyap64 wants to merge 4 commits into
Conversation
✅ Deploy Preview for thunderous-muffin-603a62 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GET /api/coach/requests+PATCH /api/coach/requests/:type/:id) so notification UI uses one list + one action endpoint.Description
getCoachRequestsandpatchCoachRequestservice helpers and exported them fromsrc/services/coach.jsto centralize requests listing and patching, including support for API-providedactions.endpointand fallback URL resolution.src/components/notifications/NotificationsPage.jsxto load a mixed list oflesson_requestandroster_requestitems, add per-card expand/collapse details, wire lesson actions toconfirm/declineand roster actions toapprove/decline, add per-card action loading state, optimistic removal on action, rollback and toast error handling, and page/perPage pagination + reload controls.src/types/coachRequests.jsforCoachRequestItem,LessonRequestPayload,RosterRequestPayload, andRequestActionto document the new shapes used by the UI.Testing
npm testand all unit tests passed (1..5, 5 passed).npm run buildand the build completed successfully.Codex Task