Add Matchplay quick view, Best Match CTA/panel, and filter enhancements#115
Open
Studio-18 wants to merge 2 commits into
Open
Add Matchplay quick view, Best Match CTA/panel, and filter enhancements#115Studio-18 wants to merge 2 commits into
Studio-18 wants to merge 2 commits into
Conversation
✅ Deploy Preview for ttp-player-web-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/components/players/MyProfileQuickView.tsx,BestMatchCTA.tsx,BestMatchesPanel.tsx, andBestMatchCard.tsxand wired them intosrc/pages/FindPlayersPage.tsxwith direct imports (no barrels) and auseIsMobilehook.PlayersFilterBar(src/components/players/PlayersFilterBar.tsx) with optionalplayTypeandavailabilityselects and added corresponding state and handlers inFindPlayersPage.tsx(selectedPlayType,selectedAvailability,handlePlayTypeChange,handleAvailabilityChange).generateBestMatchesthat uses real player records as sources and injects dummymatchScoreandmatchReasons, then toggled the CTA (BestMatchCTA) and expandableBestMatchesPanelbehindhasMatchProfile && showBestMatches.playersandmatchProfilebut only add dummy match metadata where required.Testing
npm run buildwhich completed successfully (build warning about large chunk sizes only, no errors)./find-players, injected a stored match profile, clicked theFind my best matchCTA, and produced a screenshot atartifacts/find-players-best-matches.png, confirming the panel renders.Codex Task