Fix FindPlayersPage runtime crash by reordering bestMatches initialization#123
Open
sahilkashyap64 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
bestMatchesreferencingfilteredPlayersbefore it is defined insrc/pages/FindPlayersPage.tsxso the page no longer throwsCannot access '$t' before initializationat runtime.Description
bestMatchesuseMemoso it is declared after thefilteredPlayersuseMemo, preserving the original fallback behavior of usingplayerswhen no filtered results exist and only computing matches when a profile is present.Testing
npm run buildand the build completed successfully.Codex Task