Allow charon to search aliases when fetching deps #1898
Conversation
Check if the incoming hostname is an alias, if it's not, do the normal dep logic
| params = {} | ||
| } | ||
| var self = this | ||
| return Instance.findByIdAsync(this._id) |
There was a problem hiding this comment.
Could we not add .bind(this) here and not use self?
lib/models/mongo/instance.js
Outdated
| throw new Instance.NotFoundError('Not masterpod and not isolated!') | ||
| } | ||
| return Instance.findOneBy(query) | ||
| .then(instance => { |
| // Annotate dependencies with additional instance information (currently | ||
| // only adding network information for charon) | ||
| return Promise | ||
| .map(dependencies, dep => Instance.findByIdAsync(dep.instanceId)) |
There was a problem hiding this comment.
Could we batch this into one fetch? This is going to be called a bunch from charon I'm guessing and speed of this is important. Unless we don't think it's a concern for the moment.
There was a problem hiding this comment.
charon only calls it with the hostname, the UI calls for all of them, so it should only ever be 1 call.
There was a problem hiding this comment.
I see. So it's the UI call that'll be slow? Otherwise what's up with the else on line 1182, and what's the scenario it'd be ran and how that'd only be 1 array item.
There was a problem hiding this comment.
It was when instances had deps of themselves. This was a to remove them from showing up in the UI. I'm not sure what you mean about the 1 item array
Adding more specific errors Add unit tests
…N-5803-charon-aliases
(This is why we test)
configs/.env.development
Outdated
| REDIS_PORT=6379 | ||
| S3_CONTEXT_RESOURCE_BUCKET=runnable.context.resources.development | ||
| ALLOW_ALL_CORS=true | ||
| AWS_ALIAS_HOST=us-west-2.compute.internal |
lib/models/mongo/instance.js
Outdated
| method: 'InstanceSchema.methods.convertAliasesToDeps' | ||
| }) | ||
| log.info('called') | ||
| return Promise.try(() => { |
There was a problem hiding this comment.
Promise.method instead of .try
Myztiq
left a comment
Myztiq
left a comment
There was a problem hiding this comment.
Nits, please change those 2 things and we should be good.
Charon calls GET instance/id/dependencies/hostname
Check if the incoming hostname is an alias, if it's not, do the normal dep logic