Skip to content

Conversation

@podviaznikov
Copy link
Member

@podviaznikov podviaznikov commented Sep 13, 2016

Update to ponos,
renamed queues to follow our convention.

Requires devops-scripts change CodeNow/devops-scripts#549

tasks: [
{
name: program.queue,
jobSchema: joi.object({}).unknown()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well not define this ... It's an optional argument

Copy link
Member Author

@podviaznikov podviaznikov Sep 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe keep it? at least it will validate that job is an object

@anandkumarpatel
Copy link
Contributor

few naming nits but super nice work! getting everything nice and CLEAN

@anandkumarpatel
Copy link
Contributor

@podviaznikov podviaznikov merged commit e44d1c5 into master Sep 13, 2016
@podviaznikov podviaznikov deleted the update-ponos-to-v-5 branch September 13, 2016 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants