Skip to content

[Update] Validation of the study review form #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saseungmin merged 1 commit into from
Jan 13, 2021
Merged

[Update] Validation of the study review form #144

saseungmin merged 1 commit into from
Jan 13, 2021

Conversation

@saseungmin
Copy link
Collaborator

@saseungmin saseungmin commented Jan 13, 2021 •
edited
Loading

  • 사용자가 존재하고 사용자가 작성자가 아니고 접수 마감일이 지났을 때만 스터디 후기 작성 폼이 나타나게 하기

@saseungmin
[Update] Validation of the study review form
401ed7f 
- When the user exists and the user is not the author and the deadline has passed
@saseungmin saseungmin added the enhancement New feature or request label Jan 13, 2021
saseungmin
saseungmin commented Jan 13, 2021
View reviewed changes
src/components/introduce/StudyReviewForm.jsx
Comment on lines +57 to +60
// TODO: 수정하자.
if (isValidateUserInfo(user)(moderatorId) || !isCheckedTimeStatus(valid)) {
return null;
}
Copy link
Collaborator Author

@saseungmin saseungmin Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좀 더 좋게 변경할 수 있을거 같다. 수정해보자.

@saseungmin saseungmin merged commit d02cabb into CodeSoom:main Jan 13, 2021
@saseungmin saseungmin mentioned this pull request Jan 13, 2021
Open
32 tasks
@saseungmin saseungmin mentioned this pull request Apr 9, 2021
Closed
@saseungmin saseungmin deleted the study-review-validate-status branch July 5, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@saseungmin