[Feature] Register for study group #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create actions for clearWriteFields - Create api writeStudyGroup and axios postStudyGroup - success write test
saseungmin
commented
Nov 25, 2020
Comment on lines
+3
to
+5
| import { useDispatch, useSelector } from 'react-redux'; | ||
|
|
||
| import { useHistory } from 'react-router-dom'; |
Collaborator
Author
There was a problem hiding this comment.
์ฌ๊ธด ๋ถ์ฌ์ฃผ๋๊ฒ ๋์๋ณด์ธ๋ค.
Comment on lines
+19
to
+22
| const onSubmit = useCallback(() => { | ||
| // TODO: write form validate ์ฒดํฌ ํ๊ธฐ | ||
| dispatch(writeStudyGroup()); | ||
| }, [dispatch]); |
Collaborator
Author
There was a problem hiding this comment.
writeField๊ฐ ๋น์นธ์ด๋ฉด ๋ฑ๋ก๋ชปํ๊ฒ ๋ง๋ validate๋ฅผ ์ฒดํฌํด์ฃผ๋ ๋ก์ง ๊ตฌํํด์ฃผ๊ธฐ
Comment on lines
+91
to
+92
| // NOTE: ํ์ฌ ๋ก๊ทธ์ธ ๊ธฐ๋ฅ์ด ์๋ ๊ด๊ณ๋ก ์์๋ก ์์ฑ์(moderatorId)๋ฅผ ๋ฃ์ด์ค | ||
| const group = await postStudyGroup({ ...writeField, moderatorId: 'user1' }); |
Collaborator
Author
There was a problem hiding this comment.
- ์ถํ ๋ก๊ทธ์ธ ๊ธฐ๋ฅ ๊ตฌํ ํ ๋ณ๊ฒจํด์ฃผ๊ธฐ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ฏ ์งํ ์ฌํญ
๐ค ์ฐธ๊ณ ์ฌํญ