Added persistent text and dark/light mode.#6
Closed
KrishGarg wants to merge 1 commit intoCodeWithHarry:masterfrom
KrishGarg:persisting-theme-and-text
Closed
Added persistent text and dark/light mode.#6KrishGarg wants to merge 1 commit intoCodeWithHarry:masterfrom KrishGarg:persisting-theme-and-text
KrishGarg wants to merge 1 commit intoCodeWithHarry:masterfrom
KrishGarg:persisting-theme-and-text
Conversation
Author
|
Also forgot to mention that also added the dynamic text on the Dark mode toggle so it says 'Disable Darkmode' when dark mode is enabled and vice versa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added persistent text and persistent themes.
Now if the user changes the pages or reloads the page, the theme and the text will stay as it was.
I also fixed the small thing in which the Home and About item of the navbar wasn't getting updated (bold) when the user switched pages.
PS: Thank you so much harry bhai, this pull request was possible because of you!