Skip to content

London | 26-ITP-January | Karla Grajales | Sprint 2 | Form Controls #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Grajales-K wants to merge 21 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-January | Karla Grajales | Sprint 2 | Form Controls #923

Grajales-K wants to merge 21 commits into from
+64 −23

Conversation

@Grajales-K
Copy link

@Grajales-K Grajales-K commented Jan 5, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

In this project, we built a semantic and accessible HTML form designed to verify returning customers and collect their t-shirt preferences.

Questions

no

@Grajales-K
New branch done and title of the page in html
31b45e7
@Grajales-K
removed meta instruction unused
d4751b0
@Grajales-K
added
5c6194f 
-notes.md to make notes about the project

-style.css file
@Grajales-K
added:
c26d36d 
-title
-form
-first fieldset for colors
@Grajales-K
added fieldset user details
2933319
@Grajales-K
added fieldset for size
f092d32
@Grajales-K
added fieldset date and button submit form
1e4d266
@Grajales-K
update description in the meta
8d4e339
@Grajales-K
notes
bea249d
@Grajales-K
added
bb8181e 
-file img
- favicon img
@Grajales-K
removed
a5df516 
-link meta for favicon

-img file
@Grajales-K
removed notes.md no required
76b259e
@Grajales-K
removed file style.css because no style is required
cf383d6
@Grajales-K
removed
6d1a7c3 
-fieldset password because we still can validate name and email
@Grajales-K
updated
170708c 
-legend for costomer details

-corrected name in the li yellow
@Grajales-K
updated the place holder in the user Name
f7ed400
@Grajales-K
removed delivery pick date, no in the requiments
6dc97e0
@Grajales-K
cleaning some classes unused
08583cd
@netlify
Copy link

netlify bot commented Jan 5, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit adc5fc2
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/695d7cd24dccd70008aebf7a
😎 Deploy Preview https://deploy-preview-923--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 88 (🟢 up 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Grajales-K Grajales-K added 🏕 Priority Mandatory This work is expected 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. Module-Onboarding The name of the module. Submit:Slack This work is submitted by creating or participating in a discussion on Slack. Submit:Issue This work is submitted by commenting on your copy of this Issue in your own fork of this module. and removed 🏕 Priority Mandatory This work is expected 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. labels Jan 5, 2026
@Grajales-K Grajales-K added Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. and removed Module-Onboarding The name of the module. Submit:Issue This work is submitted by commenting on your copy of this Issue in your own fork of this module. Submit:Slack This work is submitted by creating or participating in a discussion on Slack. labels Jan 5, 2026
@Grajales-K Grajales-K changed the title London | 26-ITP-January | Karla Grajales | Sprint 1 | Form-Controls London | 26-ITP-January | Karla Grajales | Sprint 2 | Form-Controls Jan 5, 2026
@Grajales-K Grajales-K changed the title London | 26-ITP-January | Karla Grajales | Sprint 2 | Form-Controls London | 26-ITP-January | Karla Grajales | Sprint 2 | Form Controls Jan 5, 2026
@Grajales-K Grajales-K added ⚙️ bug Something isn't working 🏕 Priority Mandatory This work is expected 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 5, 2026
@Grajales-K Grajales-K removed the ⚙️ bug Something isn't working label Jan 5, 2026
@Grajales-K Grajales-K mentioned this pull request Jan 6, 2026
Open
3 tasks
@jenny-alexander jenny-alexander self-requested a review January 14, 2026 13:06
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jenny-alexander jenny-alexander Awaiting requested review from jenny-alexander

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Module-Onboarding The name of the module. 🏕 Priority Mandatory This work is expected Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. 📅 Sprint 2 Assigned during Sprint 2 of this module Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Grajales-K @jenny-alexander