Skip to content

fix(autocomplete): update autocomplete design #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishichawda merged 3 commits into from
Jan 1, 2019
Merged

fix(autocomplete): update autocomplete design #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a9bc69
fix(autocomplete): update autocomplete design
rishichawda Dec 28, 2018
a27e81c
fix(autocomplete): fix no results message
rishichawda Dec 31, 2018
6816b8d
test(autocomplete): fix broken test
rishichawda Dec 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/autocomplete/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ class AutoComplete extends Component {
{item[`${labelKey}`]}
</div>
);
}) : 'No results found!';
}) : <span className={theme['no-results']}>No results found!</span>;
};

render() {
Expand Down
2 changes: 1 addition & 1 deletion lib/autocomplete/tests/edgecases.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('AutoComplete Edge Cases tests', () => {
wrappedComponent.setProps({ data: [] });
const simulatedValue = () => wrappedComponent
.find('#autocomplete-list')
.children().length;
.children('div').length;

wrappedComponent.find('input').simulate('focus');
expect(simulatedValue()).equal(expectedValue);
Expand Down
31 changes: 15 additions & 16 deletions lib/autocomplete/theme.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
@import '../globals/_theme.scss';
@import '../globals/animations.module.scss';
@import '../globals/common.scss';

:local(.autocomplete) {
@include customScroll();
width: 16em;
Expand All @@ -18,43 +17,43 @@
border: none;
border-bottom: 2px solid $input-bottom-border;
outline: none;
&:focus {
border-bottom: 2px solid $secondary-input-active-border;
}
}
}


:local(.autocomplete-list) {
z-index: 1;
box-sizing: border-box;
height: fit-content;
height: -moz-fit-content;
text-align: center;
max-height: 300px;
width: 100%;
overflow-y: auto;
box-shadow: $dropdown-menu-shadow;
border-radius: 2px;
margin-top: 10px;
margin-top: 0.2em;
padding: 2% 0;
position: absolute;
background-color: white;

@include sectionEntry(0.25s);

:local(.no-results) {
display: flex;
padding: 2% 5%;
box-sizing: border-box;
color: rgba(0, 0, 0, 0.5);
font-size: 0.8em;
}
:local(.autocomplete-list-item) {
display: block;
box-sizing: border-box;
text-align: left;
cursor: pointer;
padding: 2% 2%;
padding: 5% 4%;
box-shadow: none;
&:hover {
background-color: $input-active-item;
background-color: rgba(160, 198, 255, 0.77);
}
}
:local(.item-hover) {
background-color: $input-active-item;
background-color: rgba(160, 198, 255, 0.77);
}
}
}
Expand All @@ -63,16 +62,16 @@
&::after {
content: '';
display: block;
background-color: $primary-input-active-border !important;
background-color: rgba(160, 198, 255, 0.77) !important;
height: 2px;
@include inputFocus();
animation-duration: 0.3s;
animation-timing-function: linear;
margin-top: -2px;
position: relative;
/* Safari only style */
@media not all and (min-resolution:.001dpcm) {
bottom: 2px;
@media not all and (min-resolution: .001dpcm) {
bottom: 2px;
}
}
}