Merged
Conversation
rishichawda
added
design-update 🎨
kaushiknishchay
suggested changes
Dec 31, 2018
Contributor
kaushiknishchay
left a comment
kaushiknishchay
left a comment
There was a problem hiding this comment.
- Add Padding to Modal body
- Add bit of margin to Modal Header
Modal Close Icon:
- Can be replaced by a
×html symbol instead of using a SVG. - Add padding to it
- Can be aligned with Modal header (see screenshot)
Contributor
|
kaushiknishchay
suggested changes
Jan 2, 2019
added text overflow on title and adjust close button pos
kaushiknishchay
approved these changes
Jan 2, 2019
Contributor
Author
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status :
Ready
Description :
Update modal design and animation
Related Issues :
#287
Todos