Skip to content

popover design updates #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishichawda merged 4 commits into from
Jan 2, 2019
Merged

popover design updates #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cde2d7
fix(popover): fix popover shadow
rishichawda Dec 31, 2018
227ac02
fix(popover): update popover background and font, add separator
rishichawda Dec 31, 2018
20aaac0
test(popover): fix breaking test
rishichawda Dec 31, 2018
7c45f25
fix(popover): fix popover arrow color
rishichawda Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/popover/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ class Popover extends React.Component {
tabIndex={0}
>
{title && <span className={theme.title} aria-label="popover-title">{title}</span>}
{ title && <hr /> }
<div className={classnames(theme.popoverContent)}>{content}</div>
{!noAction && this.renderActionContent()}
<span className={theme.popoverArrow} />
Expand Down
4 changes: 2 additions & 2 deletions lib/popover/tests/accessibility.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ describe('Popover accessibility tests', () => {
.props
.children;
simulateEvent(Button, 'click');
expect(actualValue()[2].props['aria-label']).to.equal(expectedValueBefore);
expect(actualValue()[3].props['aria-label']).to.equal(expectedValueBefore);
wrappedComponent.setProps({ noAction: true });
expect(actualValue()[2]).to.equal(expectedValueAfter);
expect(actualValue()[3]).to.equal(expectedValueAfter);
});

it('Should not render title when title prop is not passed', () => {
Expand Down
21 changes: 17 additions & 4 deletions lib/popover/theme.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
}

:local(.popoverWrapper) {
filter: drop-shadow(1px 1px 3px rgba(0, 0, 0, 0.3));
margin: 2% 1%;
padding: 10px;
/*
Expand All @@ -21,16 +22,28 @@
white-space: nowrap;
max-width: 100px;
border-radius: 5px;
background-color: $secondary-white;
background-color: #ffffff;
position: absolute;
box-shadow: 1px 0px 8px 1px rgba(0, 0, 0, 0.3);
outline: none;
font-size: 0.9em;
z-index: 999; // render on top of any content
font-variant-ligatures: none;
-webkit-font-variant-ligatures: none;
text-rendering: optimizeLegibility;
-moz-osx-font-smoothing: grayscale;
font-smooth: antialiased;
-webkit-font-smoothing: antialiased;
text-shadow: rgba(0, 0, 0, .01) 0 0 1px;
hr {
width: 100%;
height: 1px;
background-color: rgba(0, 0, 0, 0.3);
border: none;
}
}

:local(.title) {
display: inline-block;
font-size: 18px;
font-weight: bold;
text-transform: capitalize;
margin-bottom: 10px;
Expand All @@ -57,7 +70,7 @@
display: inline-block;
min-width: 12px;
min-height: 12px;
background-color: $secondary-white;
background-color: #ffffff;
}

/* top positions */
Expand Down