Skip to content

Select design updates#304

Merged
rishichawda merged 2 commits intodevelopmentfrom
select-design-updates
Jan 2, 2019
Merged

Select design updates#304
rishichawda merged 2 commits intodevelopmentfrom
select-design-updates

Conversation

@rishichawda
Copy link
Contributor

@rishichawda rishichawda commented Jan 2, 2019

Status :

Ready

Description :

Update select design and minor bug fix.

Related Issues :

#287

Todos

  • Tests
  • Documentation

@rishichawda rishichawda added this to the v1.0.1 milestone Jan 2, 2019
@rishichawda rishichawda self-assigned this Jan 2, 2019
@rishichawda rishichawda changed the base branch from master to development January 2, 2019 06:35
@codecov-io
Copy link

Codecov Report

Merging #304 into development will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #304      +/-   ##
===============================================
- Coverage        92.93%   92.93%   -0.01%     
===============================================
  Files               26       26              
  Lines              864      863       -1     
===============================================
- Hits               803      802       -1     
  Misses              61       61
Impacted Files Coverage Δ
lib/select/index.js 94.11% <100%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abfeb5d...ba4d361. Read the comment docs.

KRRISH96
KRRISH96 previously approved these changes Jan 2, 2019
Copy link
Contributor

@KRRISH96 KRRISH96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kaushiknishchay kaushiknishchay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase the font size of the selected value

screenshot 2019-01-02 at 12 22 02 pm

@rishichawda
Copy link
Contributor Author

@kaushiknishchay Update the font size.

@rishichawda rishichawda merged commit 68ee49a into development Jan 2, 2019
@rishichawda rishichawda deleted the select-design-updates branch January 2, 2019 08:30
@rishichawda
Copy link
Contributor Author

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants